H. Peter Anvin wrote: > Masami Hiramatsu wrote: >> >> Hmm, I have an idea about instruction table. Usually, instruction tables >> are encoded with code defined by each decoder/emulator. This method >> will show their internal code directly, and is hard to maintain when >> the opcode map is updated. Instead of that, I'd like to suggest using >> the expressions in the opcode maps in a vender's genuine document (in >> this case, Intel/AMD's manual) or www.sandpile.org for instruction >> tables. >> > > Yes, we discussed this at the Collab Summit. I think it's the only sane > thing. > >> e.g. >> >> const insn_attr_t onebyte_attr_table[ATTR_TABLE_SIZE] = { >> /* 0x00-0x0f */ >> AT2(Eb,Gb), AT2(Ev,Gv), AT2(Gb,Eb), AT2(Gv,Ev), >> AT2(AL,Ib), AT2(rAX,Iz), AT2(ES,i64), AT2(ES,i64), >> AT2(Eb,Gb), AT2(Ev,Gv), AT2(Gb,Eb), AT2(Gv,Ev), >> AT2(AL,Ib), AT2(rAX,Iz), AT2(CS,i64), AT(ESC), >> ... >> >> Here, AT and AT2 macros are defined as follows: >> > > I would suggest using an actual parser, rather than relying on cpp for > this. The parser will be much more powerful, and will make it much > easier to change data structure radically as we discussed. Aah, I see. So we'd better make a parser which generates internal data structure from genuine opcode map in compilation time. And I changed my mind about internal data structure too. In this version, I'll use a smallest bits which are needed for the decoder. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html