On Wed, May 11, 2016 at 09:12:50AM +0200, Thomas Huth wrote: > On 10.05.2016 19:32, Andrew Jones wrote: > > Don't assume all pbus (cpu physical bus) translations will use the same > > number of address and size cells as are defined in the root node. > > That's a good idea, of course. > > > Also, > > drop the caching of the address/size cells in the bus structure, as that > > was a bad idea, and unused anyway. > > Maybe do it in a separate patch? OK > > > (I was tempted to completely remove dt_pbus_translate_node, which still > > uses the root node's address/size cells, but I kept it, as it offers a > > nice shortcut for when we are sure we can use the root node's cells.) > > Sounds like this function could cause quite a bit of confusion in the > future... maybe it would be better to remove it so that no one can use > it in the wrong way anymore? Agreed, and on 2nd (or is it 3rd) thought, I can keep it, but there's no good reason to use the root node's cells. It can work just like before this patch, that is, be the equivalent of dt_pbus_translate, but operate on the node instead of the device. Thanks, drew > > Thomas > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
