Re: [PATCH v3 8/9] run_tests: print summary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2016-05-10 13:45+0200, Paolo Bonzini:
> On 19/04/2016 09:19, Andrew Jones wrote:
>> On Fri, Apr 15, 2016 at 10:52:50PM +0200, Radim Krčmář wrote:
>>>      # extra_params in the config file may contain backticks that need to be
>>> -    # expanded, so use eval to start qemu
>>> -    eval $cmdline
>>> +    # expanded, so use eval to start qemu.  Same for $RUNTIME_log_stdout.
>>> +    summary=$(eval $cmdline > >(eval "tee -a $RUNTIME_log_stdout" | extract_summary))
>> 
>> The depth of our stdout resolution is getting insane. Oh well, let's see
>> how deep we can go before we throw our hands up and just rewrite all these
>> bash scripts in python.
> 
> Why not just use a pipe here?
> 
> eval $cmdline 2>> $RUNTIME_log_stderr \
>               | eval tee -a "$RUNTIME_log_stdout" | extract_summary
> 
> Anything I am missing?
> 
>>>      ret=$?

Simple pipeline would not return the return value of `eval $cmdline`, so
it seemed nicer with a redirection.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux