On Thu, May 05, 2016 at 04:26:33PM +0200, Alexander Gordeev wrote:
> Andrew et al,
>
> This is 7th attempt to make mainly x86 arch code consistent
> with other architectures.
>
> I withdrew your Reviewed-by from "x86: Cleanup PT_*_MASK flags"
> patch 09/11 due to couple of more than just nits changes.
>
> PCD-ed ioremap() could be a follow-up update on top of this series.
>
> Changes since v6:
> - ioremap() PCD comment updated;
> - PT_PSE_MASK renamed to PT_PAGE_SIZE_MASK;
> - GENMASK_ULL used for PT_ADDR_MASK definition;
> - missed x86/taskswitch2.c update added;
I guess you found this by compiling 32bit x86. Good. Did you make
sure both 32 and 64 bit can compile with each patch applied one
at a time? If so, then (at least as far as I'm concerned) this
series looks good to go.
Radim, can you take a look and consider it for merge?
Thanks,
drew
>
> Changes since v5:
> - ioremap() PCD comment added, the Reviewed-by preserved;
> - page table flag names changed from PTE_* to PT_*_MASK;
>
> Changes since v4:
> - single instead of multiple pages allocation bug fixed in x86 ioremap();
> - style fixes squashed into code movements for lib/x86/asm/page.h and
> lib/x86/asm/barrier.h;
> - #ifndef __ASSEMBLY__ added to lib/x86/asm/page.h;
>
> Changes since v3:
> - x86 PAGE_* constants and PTE_* flags cleaned up;
> - missing Reviewed-bys restored;
> - missing headers to lib/x86/asm/page.h and lib/x86/asm/barriers.h added
> (I did not remove already given Reviewed-bys from these);
>
> Changes since v2:
> - x86 ioremap() address arithmetics nonsense fixed;
> - x86 virt_to_phys() and phys_to_virt() implementations left intact;
> - separate overrides of virt_to_phys() and phys_to_virt() added;
> - unsigned long size specifier removed from PAGE_SIZE constant;
>
> Changes since v1:
> - arm compilation error fixed;
> - disabling memory re-ordering for generic memory barriers added;
>
>
> Cc: Andrew Jones <drjones@xxxxxxxxxx>
> Cc: Thomas Huth <thuth@xxxxxxxxxx>
> Cc: Radim Krčmář <rkrcmar@xxxxxxxxxx>
>
>
> Alexander Gordeev (11):
> Remove unused and unnecessary PHYS32 macro
> Move phys_addr_t type definition to lib/libcflat.h
> x86: Introduce lib/x86/asm/page.h
> x86: Introduce lib/x86/asm/io.h
> x86: Introduce lib/x86/asm/barrier.h
> io: Separate overrides of virt_to_phys() and phys_to_virt()
> io: Disallow memory re-ordering for generic memory barriers
> x86: Cleanup PAGE_* constants
> x86: Cleanup PT_*_MASK flags
> io: Make ioremap() prototype conform to Linux one
> x86: io: Factor out ioremap()
>
> arm/selftest.c | 1 -
> lib/alloc.h | 5 -----
> lib/arm/asm/page.h | 2 --
> lib/asm-generic/io.h | 13 +++++++++----
> lib/libcflat.h | 2 ++
> lib/powerpc/asm/setup.h | 1 -
> lib/ppc64/asm/io.h | 2 ++
> lib/x86/asm/barrier.h | 13 +++++++++++++
> lib/x86/{ => asm}/io.h | 18 ++++++++++++++++--
> lib/x86/asm/page.h | 45 +++++++++++++++++++++++++++++++++++++++++++++
> lib/x86/asm/pci.h | 2 +-
> lib/x86/io.c | 18 +++++++++++++++++-
> lib/x86/smp.h | 4 ----
> lib/x86/vm.c | 37 ++++++++++---------------------------
> lib/x86/vm.h | 25 ++-----------------------
> x86/access.c | 14 ++------------
> x86/asyncpf.c | 2 +-
> x86/eventinj.c | 17 ++++++-----------
> x86/hypercall.c | 2 +-
> x86/hyperv.c | 1 +
> x86/hyperv.h | 1 -
> x86/hyperv_stimer.c | 2 +-
> x86/hyperv_synic.c | 1 -
> x86/init.c | 2 +-
> x86/kvmclock.c | 1 +
> x86/pku.c | 2 +-
> x86/rmap_chain.c | 2 +-
> x86/smap.c | 6 +++---
> x86/svm.c | 1 -
> x86/taskswitch2.c | 2 +-
> x86/vmexit.c | 11 ++---------
> x86/vmx.c | 1 -
> x86/vmx.h | 2 +-
> x86/vmx_tests.c | 1 -
> 34 files changed, 140 insertions(+), 119 deletions(-)
> create mode 100644 lib/x86/asm/barrier.h
> rename lib/x86/{ => asm}/io.h (74%)
> create mode 100644 lib/x86/asm/page.h
>
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
