Re: [kvm-unit-tests PATCH v4 12/12] x86: io: Factor out ioremap()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 02, 2016 at 03:59:32PM +0200, Alexander Gordeev wrote:
> Cc: Andrew Jones <drjones@xxxxxxxxxx>
> Cc: Thomas Huth <thuth@xxxxxxxxxx>
> Cc: Radim Krčmář <rkrcmar@xxxxxxxxxx>
> Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx>
> ---
>  lib/x86/asm/io.h |  2 ++
>  lib/x86/io.c     | 15 +++++++++++++++
>  x86/vmexit.c     | 10 ++--------
>  3 files changed, 19 insertions(+), 8 deletions(-)
> 
> diff --git a/lib/x86/asm/io.h b/lib/x86/asm/io.h
> index 83387b5..2436822 100644
> --- a/lib/x86/asm/io.h
> +++ b/lib/x86/asm/io.h
> @@ -49,4 +49,6 @@ static inline void *phys_to_virt(unsigned long phys)
>      return (void *)phys;
>  }
>  
> +void __iomem *ioremap(phys_addr_t phys_addr, size_t size);
> +
>  #endif
> diff --git a/lib/x86/io.c b/lib/x86/io.c
> index d396d42..700666e 100644
> --- a/lib/x86/io.c
> +++ b/lib/x86/io.c
> @@ -1,6 +1,8 @@
>  #include "libcflat.h"
> +#include "vm.h"
>  #include "smp.h"
>  #include "asm/io.h"
> +#include "asm/page.h"
>  #ifndef USE_SERIAL
>  #define USE_SERIAL
>  #endif
> @@ -81,3 +83,16 @@ void exit(int code)
>          asm volatile("out %0, %1" : : "a"(code), "d"((short)0xf4));
>  #endif
>  }
> +
> +void __iomem *ioremap(phys_addr_t phys_addr, size_t size)
> +{
> +	phys_addr_t base = phys_addr & PAGE_MASK;
> +	phys_addr_t offset = phys_addr - base;
> +	ulong nr_pages = ALIGN(offset + size, PAGE_SIZE) >> PAGE_SHIFT;
> +	void *page = alloc_vpages(nr_pages);
> +
> +	install_page((void *)read_cr3(), base, page);

You need to loop over install_page() nr_pages times, otherwise you're
only installing the first page.

> +
> +	return page + offset;
> +}
> +
> diff --git a/x86/vmexit.c b/x86/vmexit.c
> index db7dbd8..c2e1e49 100644
> --- a/x86/vmexit.c
> +++ b/x86/vmexit.c
> @@ -371,8 +371,7 @@ int main(int ac, char **av)
>  {
>  	struct fadt_descriptor_rev1 *fadt;
>  	int i;
> -	unsigned long membar = 0, base, offset;
> -	void *m;
> +	unsigned long membar = 0;
>  	pcidevaddr_t pcidev;
>  
>  	smp_init();
> @@ -394,12 +393,7 @@ int main(int ac, char **av)
>  			}
>  			if (pci_bar_is_memory(pcidev, i)) {
>  				membar = pci_bar_addr(pcidev, i);
> -				base = membar & ~4095;
> -				offset = membar - base;
> -				m = alloc_vpages(1);
> -				
> -				install_page((void *)read_cr3(), base, m);
> -				pci_test.memaddr = m + offset;
> +				pci_test.memaddr = ioremap(membar, PAGE_SIZE);
>  			} else {
>  				pci_test.iobar = pci_bar_addr(pcidev, i);
>  			}
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux