On Fri, Apr 29, 2016 at 01:38:06PM +0200, Alexander Gordeev wrote: > Currently PAGE_SIZE constant defaults to unsigned long > which does not appear brings any value. > > Cc: Andrew Jones <drjones@xxxxxxxxxx> > Cc: Thomas Huth <thuth@xxxxxxxxxx> > Cc: Radim Krčmář <rkrcmar@xxxxxxxxxx> > Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx> > --- > lib/x86/asm/page.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/x86/asm/page.h b/lib/x86/asm/page.h > index db834ba..365d269 100644 > --- a/lib/x86/asm/page.h > +++ b/lib/x86/asm/page.h > @@ -1,7 +1,7 @@ > #ifndef _ASM_X86_PAGE_H_ > #define _ASM_X86_PAGE_H_ > > -#define PAGE_SIZE 4096ul > +#define PAGE_SIZE 4096 nack If PAGE_SIZE is only an int (32bits) then PAGE_MASK, which is (~(PAGE_SIZE-1)), would only be 0xfffff000, rather than 0xfffffffffffff000, as it should be. > #ifdef __x86_64__ > #define LARGE_PAGE_SIZE (512 * PAGE_SIZE) > #else > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
