Re: [PATCH RFC 11/15] pci/x86: Adopt PCI framework changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 11, 2016 at 01:04:23PM +0200, Alexander Gordeev wrote:
> Cc: Thomas Huth <thuth@xxxxxxxxxx>
> Cc: Andrew Jones <drjones@xxxxxxxxxx>
> Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx>
> ---
>  lib/x86/asm/pci.h | 2 ++
>  x86/vmexit.c      | 4 ++++
>  2 files changed, 6 insertions(+)


Let's drop this patch. It doesn't do anything now, and won't do
anything (probably) ever. It only clutters the x86 code.

thanks,
drew

> 
> diff --git a/lib/x86/asm/pci.h b/lib/x86/asm/pci.h
> index 917da19ac36c..533b45e2da63 100644
> --- a/lib/x86/asm/pci.h
> +++ b/lib/x86/asm/pci.h
> @@ -35,4 +35,6 @@ static inline void pci_config_writel(pcidevaddr_t dev, uint8_t reg, uint32_t val
>      outl(val, 0xCFC);
>  }
>  
> +#include <asm-generic/pci.h>
> +
>  #endif
> diff --git a/x86/vmexit.c b/x86/vmexit.c
> index a3d3b841110d..11eb01a9c178 100644
> --- a/x86/vmexit.c
> +++ b/x86/vmexit.c
> @@ -386,6 +386,8 @@ int main(int ac, char **av)
>  	pm_tmr_blk = fadt->pm_tmr_blk;
>  	printf("PM timer port is %x\n", pm_tmr_blk);
>  
> +	pci_probe();
> +
>  	pcidev = pci_find_dev(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_TEST);
>  	if (pcidev != PCIDEVADDR_INVALID) {
>  		for (i = 0; i < PCI_TESTDEV_NUM_BARS; i++) {
> @@ -407,5 +409,7 @@ int main(int ac, char **av)
>  		if (test_wanted(&tests[i], av + 1, ac - 1))
>  			while (do_test(&tests[i])) {}
>  
> +	pci_shutdown();
> +
>  	return 0;
>  }
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux