2016-04-19 09:26+0200, Andrew Jones: > On Fri, Apr 15, 2016 at 10:52:51PM +0200, Radim Krčmář wrote: >> After recent changes to logging, seeing it all the time doesn't help. >> We could print one line in summary if stderr is missed. > > I miss it already :-) > > I like stderr coming to the terminal from which run_tests.sh is run, > because it should be rare and probably important to see. I'd rather > this patch at least include the one summary line now, rather than > wait and see if we want it later. Messages in stderr aren't rare, though ... we see several of them on every batch: warning: host doesn't support requested feature: CPUID.80000001H:ECX.svm [bit 2] warning: host doesn't support requested feature: CPUID.80000001H:ECX.svm [bit 2] warning: host doesn't support requested feature: CPUID.01H:ECX.vmx [bit 5] (Warnings already screw up our FAIL heuristic, so we'd better do something with them ...) > Or maybe just drop this patch? I'll drop this patch, it was borderline acceptable and making the summary bearable would might be out of my league. >> diff --git a/run_tests.sh b/run_tests.sh >> @@ -47,6 +47,7 @@ while getopts "g:hv" opt; do >> +RUNTIME_log_stderr='test.log' >> diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh >> @@ -70,6 +70,7 @@ generate_test () >> + echo "RUNTIME_log_stderr=>(cat >&2)" > > No need for the single quotes like RUNTIME_log_stdout has? Or > does RUNTIME_log_stdout not need them? *evil laugh*, both of them need quotes just where they are. RUNTIME_log_stdout is used in a subshell that wouldn't have access to the fd if we evaluated it here. RUNTIME_log_stderr has to be evaluated into the fd here, because it wouldn't be evaluated in the future. (Take a while to apprectiate this hellspawn.) >> diff --git a/scripts/runtime.bash b/scripts/runtime.bash >> @@ -61,7 +61,8 @@ function run() >> - summary=$(eval $cmdline > >(eval "tee -a $RUNTIME_log_stdout" | extract_summary)) >> + summary=$(eval $cmdline > >(eval "tee -a $RUNTIME_log_stdout" | extract_summary) \ >> + 2>> $RUNTIME_log_stderr) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
