Re: [PATCH] kvmtool: delegate exit/reboot responsibility to vcpu0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 14, 2016 at 11:57:31AM +1000, Balbir Singh wrote:
> 
> 
> On 12/04/16 01:37, Will Deacon wrote:
> > Our exit/reboot code is a bit of a mess:
> > 
> >   - Both kvm__reboot and kvm_cpu_exit send SIGKVMEXIT to running vcpus
> >   - When vcpu0 exits, the main thread starts executing destructors
> >     (exitcalls) whilst other vcpus may be running
> >   - The pause_lock isn't always held when inspecting is_running for
> >     a vcpu
> > 
> > This patch attempts to fix these issues by restricting the exit/reboot
> > path to vcpu0 and the main thread. In particular, a KVM_SYSTEM_EVENT
> > will signal SIGKVMEXIT to vcpu0, which will join with the main thread
> > and then tear down the other vcpus before invoking any destructor code.
> > 
> > Cc: Julien Grall <julien.grall@xxxxxxx>
> > Cc: Balbir Singh <bsingharora@xxxxxxxxx>
> > Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
> > ---
> > 
> > Balbir -- does this work on ppc?
> 
> 
> Yes, it does
> 
> Acked-by: Balbir Singh <bsingharora@xxxxxxxxx>
> 
> My patch for exit race fixes can be dropped in favour of this change

Thanks, Balbir! I've pushed it out, along with your ppc changes.

Will
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux