On 12/04/2016 18:22, Radim Krčmář wrote: >> > + >> > + if (apic_id > 4 || cluster_id >= 0xf) >> > + return NULL; >> > + index = (cluster_id << 2) + apic_id; > ffs(apic_id), because 'apic_id' must be compacted into 2 bits. > ffs(apic_id)-1 actually. Thanks for the review, Radim. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html