Re: [PATCH 4/5] Fix a race during exit processing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 31, 2016 at 10:28:26PM +1100, Balbir Singh wrote:
> Fix a race, described below
> 
> 	lkvm stop ...	handle_stop
> 			kvm_cpu__reboot
> 			kvm_cmd_run_exit
> 			vcpus exit
> 			...
> 			dev_exit
> 			...
> 			ioport__unregister
> 			..serial...
> 			kvm__pause --> br_write_lock
> 			pthread_kill
> 
> But the thread is already dead above.
> 
> We mark the cpus as dying so that kvm_pause does nothing.
> This should not break any semantics

I'm not convinced that this solves the whole problem. The fact of the
matter is that we're tearing down the VM whilst there may still be active
vcpus, so I'd much rather delay the teardown until we know that the vcpus
are all dead.

Patch incoming.

Will
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux