On Mon, Apr 11, 2016 at 02:06:28PM +0200, Alexander Gordeev wrote:
> On Mon, Apr 11, 2016 at 01:50:51PM +0200, Andrew Jones wrote:
> > On Mon, Apr 11, 2016 at 01:04:16PM +0200, Alexander Gordeev wrote:
> > > Cc: Thomas Huth <thuth@xxxxxxxxxx>
> > > Cc: Andrew Jones <drjones@xxxxxxxxxx>
> > > Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx>
> > > ---
> > > lib/pci.c | 36 ++++++++++++++++++------------------
> > > lib/pci.h | 2 +-
> > > 2 files changed, 19 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/lib/pci.c b/lib/pci.c
> > > index 0058d70c888d..9295c35da43d 100644
> > > --- a/lib/pci.c
> > > +++ b/lib/pci.c
> > > @@ -10,34 +10,34 @@
> > > /* Scan bus look for a specific device. Only bus 0 scanned for now. */
> > > pcidevaddr_t pci_find_dev(uint16_t vendor_id, uint16_t device_id)
> > > {
> > > - unsigned dev;
> > > - for (dev = 0; dev < 256; ++dev) {
> > > - uint32_t id = pci_config_read(dev, 0);
> > > - if ((id & 0xFFFF) == vendor_id && (id >> 16) == device_id) {
> > > - return dev;
> > > - }
> > > - }
> > > - return PCIDEVADDR_INVALID;
> > > + unsigned dev;
> >
> > While at it add an empty line here.
>
> This and likely following such suggestions are addressed in a following
> rework patch. Both patches seem good to me for fixing the style - just
> let me know whichever you prefer ;)
I'd prefer this patch to do all the code style fixes, and then not mix
code style changes into the other patches. The subject of this patch
should be updated too.
Thanks,
drew
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
