On Tue, Mar 29, 2016 at 01:13:30PM +0200, Paolo Bonzini wrote: > > > On 23/03/2016 00:35, Peter Feiner wrote: > > +if [ "$PRETTY_PRINT_STACKS" = "yes" ]; then > > + log_redir="> >(./scripts/pretty_print_stacks.py \$kernel >> test.log)" > > Isn't this the same as "| ./scripts/pretty_print_stack.py \$kernel >> > test.log"? Not the same. Consider scripts/runtime.bash's usage: cmdline="...$RUNTIME_arch_run $kernel -smp $smp $opts" With your alternative, the command-line arguments after $RUNTIME_arch_run are be passed to pretty_print_stacks.py instead of Qemu. > If so, perhaps > > if [ "$PRETTY_PRINT_STACKS" = "yes" ]; then > stack_filter="./scripts/pretty_print_stack.py \$kernel" > else > stack_filter=cat > > RUNTIME_arch_run="./$TEST_DIR/run | $stack_filter >> test.log" > > ... would be a bit easier to read. Yes, it's super ugly, but it works! Peter -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
