On Thu, Apr 09, 2009 at 09:37:10AM -0700, Stephen Hemminger wrote: > > +static int tx_ringlen = 256; > > +module_param(tx_ringlen, int, 0444); > > + > > +#undef PDEBUG /* undef it, just in case */ > > +#ifdef VBUS_ENET_DEBUG > > +# define PDEBUG(fmt, args...) printk(KERN_DEBUG "vbus_enet: " fmt, ## args) > > +#else > > +# define PDEBUG(fmt, args...) /* not debugging: nothing */ > > +#endif > > Why reinvent pr_debug()? Even more important, use dev_dbg() instead please, that uniquly describes your device and driver together, which is what you need/want, and it ties into the dynamic debug work, so you don't need a special kernel config option. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
