On 23/03/2016 18:21, Radim Krčmář wrote: > > > + * nmi pending counter is cleared to prevent skipping > > > + * injectable pending interrupts. > > > + */ > > > + if (vcpu->arch.nmi_pending && kvm_cpu_has_injectable_intr(vcpu) > > > + && kvm_x86_ops->interrupt_allowed(vcpu)) > > > + vcpu->arch.nmi_pending = 0; > > > > I am not sure I understand this. Why is it safe to drop nmi_pending? > > NMIs are latched (queue length 1) and therefore cannot be pending after > an injection. I think we want to do it unconditionally. If that is right, process_nmi would be the place where you'd limit the queue to 1. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
