Re: [kvm-unit-tests PATCH v2 4/5] powerpc: check lswx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 21/03/2016 15:25, Paolo Bonzini wrote:
> 
> 
> On 21/03/2016 13:07, Thomas Huth wrote:
>>>> +		      /* adding r1 in the clobber list doesn't protect it... */
>> You repeat that again in the comment below, so in case you respin this
>> series, you could also drop one of the two comments, I think.
> 
> I can do it while fixing the typo (arount->around).

Yes, please.

Thanks,
Laurent
> 
> Paolo
> 
>>>> +		      "mr r29,r1;"
>>>> +		      "li r31,-1;"
>>>> +		      "mr r1,r31;"
>>>> +		      "mr r0, %[addr];"
>>>> +		      "lswx r31, 0, r0;"
>>>> +		      "std r31, 0*8(%[regs]);"
>>>> +		      "std r0, 1*8(%[regs]);"
>>>> +		      "std r1, 2*8(%[regs]);"
>>>> +		      "mr r1,r29;"
>>>> +		      ::
>>>> +		      [len] "r" (12),
>>>> +		      [addr] "r" (addr),
>>>> +		      [regs] "r" (regs)
>>>> +		      :
>>>> +		      /* three registers from r31, wrap arount to r1,
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux