On Tue, Mar 15, 2016 at 12:26:29PM +0000, Julien Grall wrote: > Hi Christoffer, > > On 09/03/16 05:39, Christoffer Dall wrote: > >On Tue, Mar 08, 2016 at 11:29:29AM +0000, Julien Grall wrote: > >>Even though all the variables aren't marked with __initdata, they are > >>only used during initialization. So the structure is marked with > >>__initdata. > > > >Not sure I understand this commit message. > > > >As I see it, this commit includes two changes: > > > >1. Mark the variables only used during init with __initdata > > > >2. Move the variables into a structure > > > >If I get that right, can you argue for both changes? > > What about: > > "The ACPI code requires to use global variables in order to collect > information from the tables. > > To make clear those variables are ACPI specific, gather all of them > in a single structure. > > Furthermore, even if some of the variables are not marked with > __initdata, they are all only used during the initialization. > Therefore, the new variable, which hold the structure, can be marked > __initdata." > Looks ok (the part about some of the variables not marked with __initdata is confusing but I think I understand what you mean). Thanks, -Christoffer -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
