Re: [PATCH kvm-unit-tests v2] powerpc: fix boot_rom.bin build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/03/2016 18:09, Peter Feiner wrote:
> My powerpc objcopy (version 2.23.52.20130305) did a seek() that
> bash process substitution couldn't handle! I've changed the
> Makefile to do things the old fashioned way.
> 
> Signed-off-by: Peter Feiner <pfeiner@xxxxxxxxxx>
> 
> ---
> 
> v2:
> 	* rm the temporary file
> 	* renamed temporary file to .tmp instead of .suffix
> ---
>  powerpc/Makefile.common | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
> index 424983e..2074289 100644
> --- a/powerpc/Makefile.common
> +++ b/powerpc/Makefile.common
> @@ -48,7 +48,9 @@ FLATLIBS = $(libcflat) $(LIBFDT_archive)
>  
>  $(TEST_DIR)/boot_rom.bin: $(TEST_DIR)/boot_rom.elf
>  	dd if=/dev/zero of=$@ bs=256 count=1
> -	$(OBJCOPY) -O binary $^ >(cat - >>$@)
> +	$(OBJCOPY) -O binary $^ $@.tmp
> +	cat $@.tmp >> $@
> +	$(RM) $@.tmp
>  
>  $(TEST_DIR)/boot_rom.elf: CFLAGS = -mbig-endian
>  $(TEST_DIR)/boot_rom.elf: $(TEST_DIR)/boot_rom.o
> 


Applied, thanks.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux