On Thu, Mar 03, 2016 at 12:48:36PM -0800, Peter Feiner wrote: > Optionally pretty print stacks in test.log with 'run_tests.sh -p'. > > The script runs addresses through addr2line to get file names and line > numbers. Also prints out source code lines if files are available. > For example > > 0x004013f5: ac_test_exec at x86/access.c:818 > } > > ac_test_setup_pte(at, pool); > r = ac_test_do_access(at); > 0x004014dd: ac_test_run at x86/access.c:852 > ++tests; > > successes += ac_test_exec(&at, &pool); > } while (ac_test_bump(&at)); > 0x0040157d: main at x86/access.c:873 > printf("starting test\n\n"); > > r = ac_test_run(); > return r ? 0 : 1; > 0x0040028e: start64 at x86/cstart64.S:206 > lea __argv(%rip), %rsi > > call main > mov %eax, %edi > > Signed-off-by: Peter Feiner <pfeiner@xxxxxxxxxx> > --- > run_tests.sh | 10 ++++- > scripts/pretty_print_stacks.py | 89 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 97 insertions(+), 2 deletions(-) > create mode 100755 scripts/pretty_print_stacks.py > > diff --git a/run_tests.sh b/run_tests.sh > index 89e8f84..b6f2003 100755 > --- a/run_tests.sh > +++ b/run_tests.sh > @@ -1,6 +1,7 @@ > #!/bin/bash > > verbose="no" > +pretty="no" > > if [ ! -f config.mak ]; then > echo "run ./configure && make first. See ./configure -h" > @@ -18,6 +19,7 @@ Usage: $0 [-g group] [-h] [-v] > -g: Only execute tests in the given group > -h: Output this help text > -v: Enables verbose mode > + -p: Pretty print stack traces in test.log > > Set the environment variable QEMU=/path/to/qemu-system-ARCH to > specify the appropriate qemu binary for ARCH-run. > @@ -27,8 +29,9 @@ EOF > > RUNTIME_arch_run="./$TEST_DIR/run" > source scripts/runtime.bash > +log_redir=">> test.log" > > -while getopts "g:hv" opt; do > +while getopts "g:hvp" opt; do > case $opt in > g) > only_group=$OPTARG > @@ -40,13 +43,16 @@ while getopts "g:hv" opt; do > v) > verbose="yes" > ;; > + p) > + log_redir="> >(./scripts/pretty_print_stacks.py \$kernel >> test.log)" > + ;; What about the idea of turning this on by default, and only turning it off if it was configured off? drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html