On 03.03.2016 22:55, Peter Feiner wrote:
> Tested with arch=i386, x86_64, ppc64, and arm64.
>
> Signed-off-by: Peter Feiner <pfeiner@xxxxxxxxxx>
> ---
> Makefile | 2 +-
> x86/hypercall.c | 2 +-
> x86/vmx_tests.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
...
> @@ -1392,6 +1390,7 @@ static void dbgctls_main(void)
> asm volatile("mov %%dr7,%0" : "=r" (dr7));
> debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);
> /* Commented out: KVM does not support DEBUGCTL so far */
> + assert(debugctl == debugctl);
> report("Load debug controls", dr7 == 0x404 /* && debugctl == 0x2 */);
>
> dr7 = 0x408;
> @@ -1413,6 +1412,7 @@ static void dbgctls_main(void)
> asm volatile("mov %%dr7,%0" : "=r" (dr7));
> debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);
> /* Commented out: KVM does not support DEBUGCTL so far */
> + assert(debugctl == debugctl);
> report("Guest=host debug controls", dr7 == 0x402 /* && debugctl == 0x1 */);
Now these assert()s are really ugly. Wouldn't it be better do comment
out the "debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);" line instead?
Thomas
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
