On Wed, Mar 2, 2016 at 12:47 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > On 02/03/2016 07:24, Jan Kiszka wrote: >> The kernel macro looks different from mine, but I think it gives the >> same result... yes: this must be really GENMASK(51, 12) (bits 51..12). > > While at it, it should probably be GENMASK_ULL(51, 12), even though > right now the test case is only 64-bit. Which in turn would show that > BITS_PER_LONG_LONG is not defined anywhere: > > $ git grep PER_LONG_LONG > lib/bitops.h:#define BIT_ULL_MASK(nr) (1ULL << ((nr) % BITS_PER_LONG_LONG)) > lib/bitops.h:#define BIT_ULL_WORD(nr) ((nr) / BITS_PER_LONG_LONG) > lib/bitops.h: (((~0ULL) << (l)) & (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h)))) Obviously I didn't actually run the test! It's fixed now. I've also defined BITS_PER_LONG_LONG in lib/bitops.h. Will send v3. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
