Re: [kvm-unit-tests PATCH v3 3/6] arch-run: reduce return code ambiguity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/03/2016 16:42, Radim Krčmář wrote:
>> > I'm not sure how you would have something on stderr, except on the very
>> > last line?  The idea being that 1) the test only writes to stdout 2)
>> > QEMU only writes to stderr 3) QEMU exits after writing to stderr.  If
>> > this is true, the proposed assignment/printf pair works just fine.
> 
> QEMU prints some warnings without immediately exiting, e.g.
>   warning: host doesn't support requested feature: CPUID.01H:ECX.vmx [bit 5]
> 
> So it's possible that stdout is printed after stderr.  Preserving the
> visible output could be less confusing in these rare cases.  I agree
> with the late printf if you think that the ugly code is not worth it.

Perhaps we can add an "stderr:" line if $errors is not empty, so that it
is clear that the order is not maintained.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux