On Tue, Mar 01, 2016 at 11:43:06AM +0100, Paolo Bonzini wrote: > > > On 29/02/2016 21:19, Andrew Jones wrote: > > Suggested-by: Thomas Huth <thuth@xxxxxxxxxx> > > Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> > > --- > > lib/libcflat.h | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/lib/libcflat.h b/lib/libcflat.h > > index 39100f29713b8..ce09d34e658b3 100644 > > --- a/lib/libcflat.h > > +++ b/lib/libcflat.h > > @@ -51,13 +51,15 @@ typedef _Bool bool; > > extern void puts(const char *s); > > extern void exit(int code); > > extern void abort(void); > > - > > -extern int printf(const char *fmt, ...); > > -extern int snprintf(char *buf, int size, const char *fmt, ...); > > -extern int vsnprintf(char *buf, int size, const char *fmt, va_list va); > > -extern int vprintf(const char *fmt, va_list va); > > extern long atol(const char *ptr); > > > > +#define _f(i,j) __attribute__((format(printf, i, j))) > > Please name this ATTRIBUTE_PRINTF. Do you want me to keep it defined? I used _f, only because it's short, keeping it from bloating the below lines, and then I undef'ed it when it no longer had any purpose. If we'd rather not using something like _f for the name, then I think we might as well just use the __attribute__ string as is. Thanks, drew > > Paolo > > > +extern int printf(const char *fmt, ...) _f(1,2); > > +extern int snprintf(char *buf, int size, const char *fmt, ...) _f(3,4); > > +extern int vsnprintf(char *buf, int size, const char *fmt, va_list va) _f(3,0); > > +extern int vprintf(const char *fmt, va_list va) _f(1,0); > > +#undef _f > > + > > extern void report_prefix_push(const char *prefix); > > extern void report_prefix_pop(void); > > extern void report(const char *msg_fmt, bool pass, ...); > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
