Re: [kvm-unit-tests PATCH v2 2/2] powerpc: select endianness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 26/02/2016 19:45, Andrew Jones wrote:
>> > +	LOAD_REG_ADDR(r10,rtas_return_loc)
>> > +	mtlr	r10
>> > +
>> >  	LOAD_REG_ADDR(r10, rtas_blob)
>> > -//FIXME: change this bctrl to an rtas-prep, rfid, rtas-return sequence
>> > -	mtctr	r10
>> > -	nop
>> > -	bctrl
>> > +	B_BE(r10)

Note that this doesn't apply.  I've applied patch 1 though.

Paolo

>> > +
>> > +rtas_return_loc:
>> > +	RETURN_FROM_BE
>> >  	ld	r0, 16(r1)
>> >  	mtlr	r0
>> >  	blr
> Besides my earlier comment about always needing rfid to prep for the
> rtas call (which my FIXUP comment here poorly indicated), then this
> looks good to me. Although I'm not sure I like the name RETURN_FROM_BE,
> as sometimes we're returning to LE, and sometimes we're not. In the
> not case, it's a bit confusing.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux