On Thu, Feb 18, 2016 at 01:39:52PM +1100, Alexey Kardashevskiy wrote: > > The latest powerkvm kernel passes @thp instead of NULL and check for it > below in addition to (shift > PAGE_SHIFT), should it be fixed here as well? > > Is that possible for __find_linux_pte_or_hugepte() return thp==true but > shift<=PAGE_SHIT, assuming we call it on vcpu->arch.pgdir, not an ordinary > task pgdir? Looking at the code for __find_linux_pte_or_hugepte, if it returns thp==true then it must return shift==PMD_SHIFT, which is 24 for Book3S 64 with 64k pages. With 4k pages, we don't get the option to enable THP (on Book3S 64). Other platforms might return other values, but they would always be greater than PAGE_SHIFT. Paul. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
