Hi Avi,
You said that you'd be willing to include this. I don't want to
pester or anything, but I would like it to not fall into the abyss.
Would you like me to file it as a bug and assign it to you? Are there
any changes that you'd like?
The one change you mentioned was to pull struct kvm_io outside of
struct kvm_run. I mentioned that a grep shows no usage of kvm_io
anywhere, so I didn't do that.
Nate
On Fri, Mar 27, 2009 at 9:53 PM, nathan binkert <nate@xxxxxxxxxxx> wrote:
> Two things needed fixing: 1) g++ does not allow a named structure type
> within an anonymous union and 2) Avoid name clash between two padding
> fields within the same struct by giving them different names as is
> done elsewhere in the header.
>
>
> Signed-off-by: Nathan Binkert <nate@xxxxxxxxxxx>
> ---
> include/linux/kvm.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index ee755e2..2e3a734 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -119,7 +119,7 @@ struct kvm_run {
> __u32 error_code;
> } ex;
> /* KVM_EXIT_IO */
> - struct kvm_io {
> + struct {
> #define KVM_EXIT_IO_IN 0
> #define KVM_EXIT_IO_OUT 1
> __u8 direction;
> @@ -224,10 +224,10 @@ struct kvm_interrupt {
> /* for KVM_GET_DIRTY_LOG */
> struct kvm_dirty_log {
> __u32 slot;
> - __u32 padding;
> + __u32 padding1;
> union {
> void __user *dirty_bitmap; /* one bit per page */
> - __u64 padding;
> + __u64 padding2;
> };
> };
>
> --
> 1.6.1.2
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
