On 2016/2/20 21:30, Peter Maydell wrote:
On 20 February 2016 at 13:15, Shannon Zhao<shannon.zhao@xxxxxxxxxx> wrote:
>
>
>On 2016/2/8 20:09, Christoffer Dall wrote:
>>Isn't it really a BUG_ON(p->is_write) ?
>>
>>Presumably a guest write to these registers will raise an undefined
>>exception in EL0/1 and we don't get here by any other path than the trap
>>handler, do we?
>
>Yeah, for EL1, it shouldn't get here. But for EL0, to support the function
>of PMUSERENR, we firstly trap the access to EL2, then according to the real
>value of PMUSERENR to decide whether inject an UND to EL1.
I thought the PMUSERENR check took priority over trap-to-EL2 checks
in the architecture; so if this is an EL0 access and you get to EL2
at all then you know that PMUSERENR is set to permit EL0 reads.
Similarly, UNDEF because of write-to-always-RO register has
priority over trap-to-EL2, so I think Christoffer is right
and you should never be able to get here for a write.
(This should be easy to write a test program for if you're unsure.)
Thanks, I'll check this.
--
Shannon
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
