On Fri, Feb 19, 2016 at 03:08:54PM +1100, David Gibson wrote: > On Wed, Feb 17, 2016 at 07:40:58PM +0100, Andrew Jones wrote: > > Add enough RTAS support to start adding RTAS commands. Just add > > power-off for now. > > > > Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> > > Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx> > > Tested-by: Laurent Vivier <lvivier@xxxxxxxxxx> > > Reviewed-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> > > apart from one nit below. > [...] > > + > > + for (i = 0; i < size/4; ++i) > > + if (insn[i] == SC1) > > + insn[i] = SC1_REPLACEMENT; > > Hm, technically you need some byteswapping here - cpu mode changes the > byteorder of instructions as well on Power. I know you're only > supporting BE systems for now, but you do have byteswapping for the > rtas args and so forth below, so.. Will add. Thanks, drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
