re: KVM: x86: Add lowest-priority support for vt-d posted-interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Feng Wu,

This is a semi-automatic email about new static checker warnings.

The patch 6228a0da8057: "KVM: x86: Add lowest-priority support for 
vt-d posted-interrupts" from Jan 25, 2016, leads to the following 
Smatch complaint:

arch/x86/kvm/lapic.c:875 kvm_intr_is_single_vcpu_fast()
	 error: we previously assumed 'dst' could be null (see line 868)

arch/x86/kvm/lapic.c
   867				dst = map->logical_map[cid][idx];
   868				if (!dst && !kvm->arch.disabled_lapic_found) {
                                    ^^^^
Patch introduces a new assignment and NULL check.

   869					kvm->arch.disabled_lapic_found = true;
   870					printk(KERN_INFO
   871						"Disabled LAPIC found during irq injection\n");
   872					goto out;
   873				}
   874	
   875				*dest_vcpu = dst->vcpu;
                                             ^^^^^^^^^
Old unchecked dereference.

   876			} else {
   877				for_each_set_bit(i, &bitmap, 16) {

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux