Re: [kvm-unit-tests PATCH 0/6] reduce exit status ambiguity and more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2016-01-27 11:33+0100, Andrew Jones:
> On Tue, Jan 26, 2016 at 10:55:34PM +0100, Radim Krčmář wrote:
>> 2016-01-26 19:42+0100, Andrew Jones:
>>> The first three patches makes changes to reduce the exit status ambiguity,
>>> for which kvm-unit-tests is famous. The next couple are a cleanup and a
>>> minor feature enhancement. The last is a feature enhancement bringing
>>> timeouts to unittest runs.
>> 
>> I can accept that we don't care about bugs in [3/6], so if you insist,
> 
> I never insist. I'll fix it up with your suggestions. I also thought
> of something else to fix. The standalone arch-run script is now the
> concatenation of scripts/arch-run.bash and TEST_DIR/run, the former being
> first. scripts/arch-run.bash doesn't have a '#!/bin/bash' at the top.
> I'll modify mkstandalone to make sure RUNTIME_arch_run always has bash
> specified.

True.  The sad part is that it worked in tests, because sh = bash on
many systems ...

>> Reviewed-by: Radim Krčmář <rkrcmar@xxxxxxxxxx>
> 
> I'll add your r-b's to all patches for v2. If you don't like something I
> do for the changes then just complain and revoke it :-)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux