On 22/12/15 14:50, Peter Maydell wrote: > On 22 December 2015 at 14:39, Christoffer Dall > <christoffer.dall@xxxxxxxxxx> wrote: >> On Tue, Dec 22, 2015 at 11:08:10AM +0000, Peter Maydell wrote: >>> Won't this result in our incorrectly skipping the first insn >>> in the fault handler if the original offending instruction >>> was itself the first insn in the fault handler? >>> >> Wouldn't that then loop with the exception forever? > > Yes, but so would real hardware... Indeed. As it is, this patch is not doing what it should. On the other hand, I came to the conclusion that we do not need to fix this just yet, as long as we only let KVM inject an UNDEF, and that's what the PMU code requires. I'll comment on the PMU thread, but the gist of it is: 1) fix the arm64 UNDEF/PABRT/DABRT code to properly account for the the source EL (Table D1-7 of the ARMv8 ARM). 2) instead of crafting an exception that modifies the PC, fail the sysreg access and let KVM inject an UNDEF. I'll post another patch today to address 1), and I'll finish reviewing the PMU thread (I have a separate patch addressing 2)). Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
