On 15/12/15 08:49, Shannon Zhao wrote: > From: Shannon Zhao <shannon.zhao@xxxxxxxxxx> > > Since the reset value of PMINTENSET and PMINTENCLR is UNKNOWN, use > reset_unknown for its reset handler. Add a handler to emulate writing > PMINTENSET or PMINTENCLR register. > > Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx> > --- > arch/arm64/kvm/sys_regs.c | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index f216da7..594e53f 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -648,6 +648,27 @@ static bool access_pmcntenset(struct kvm_vcpu *vcpu, struct sys_reg_params *p, > return true; > } > > +static bool access_pmintenset(struct kvm_vcpu *vcpu, struct sys_reg_params *p, > + const struct sys_reg_desc *r) > +{ > + u64 mask = kvm_pmu_valid_counter_mask(vcpu); > + > + if (p->is_write) { > + if (r->Op2 & 0x1) { > + /* accessing PMINTENSET_EL1 */ > + vcpu_sys_reg(vcpu, r->reg) |= (p->regval & mask); > + } else { > + /* accessing PMINTENCLR_EL1 */ > + vcpu_sys_reg(vcpu, r->reg) &= mask; > + vcpu_sys_reg(vcpu, r->reg) &= ~p->regval; This looks wrong. The first line doesn't have any effect (you shouldn't be able to set bits that are not in the mask the first place). I'd prefer something like: vcpu_sys_reg(vcpu, r->reg) &= ~(p->regval & mask); which is symmetrical to the SET operator. > + } > + } else { > + p->regval = vcpu_sys_reg(vcpu, r->reg) & mask; > + } > + > + return true; > +} > + > /* Silly macro to expand the DBG{BCR,BVR,WVR,WCR}n_EL1 registers in one go */ > #define DBG_BCR_BVR_WCR_WVR_EL1(n) \ > /* DBGBVRn_EL1 */ \ > @@ -806,10 +827,10 @@ static const struct sys_reg_desc sys_reg_descs[] = { > > /* PMINTENSET_EL1 */ > { Op0(0b11), Op1(0b000), CRn(0b1001), CRm(0b1110), Op2(0b001), > - trap_raz_wi }, > + access_pmintenset, reset_unknown, PMINTENSET_EL1 }, > /* PMINTENCLR_EL1 */ > { Op0(0b11), Op1(0b000), CRn(0b1001), CRm(0b1110), Op2(0b010), > - trap_raz_wi }, > + access_pmintenset, NULL, PMINTENSET_EL1 }, > > /* MAIR_EL1 */ > { Op0(0b11), Op1(0b000), CRn(0b1010), CRm(0b0010), Op2(0b000), > @@ -1204,8 +1225,8 @@ static const struct sys_reg_desc cp15_regs[] = { > { Op1( 0), CRn( 9), CRm(13), Op2( 1), access_pmu_evtyper }, > { Op1( 0), CRn( 9), CRm(13), Op2( 2), access_pmu_evcntr }, > { Op1( 0), CRn( 9), CRm(14), Op2( 0), trap_raz_wi }, > - { Op1( 0), CRn( 9), CRm(14), Op2( 1), trap_raz_wi }, > - { Op1( 0), CRn( 9), CRm(14), Op2( 2), trap_raz_wi }, > + { Op1( 0), CRn( 9), CRm(14), Op2( 1), access_pmintenset }, > + { Op1( 0), CRn( 9), CRm(14), Op2( 2), access_pmintenset }, > > { Op1( 0), CRn(10), CRm( 2), Op2( 0), access_vm_reg, NULL, c10_PRRR }, > { Op1( 0), CRn(10), CRm( 2), Op2( 1), access_vm_reg, NULL, c10_NMRR }, > Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html