On 12/15/2015 04:47 PM, Kai Huang wrote:
A further thinking is can we move it to mmu_need_write_protect? Passing can_unsync as parameter to
kvm_unsync_pages sounds a little bit odd.
+
if (s->unsync)
continue;
WARN_ON(s->role.level != PT_PAGE_TABLE_LEVEL);
How about large page mapping? Such as if guest uses 2M mapping and its shadow is indirect, does
above WARN_ON still meet? As you removed the PT level check in mmu_need_write_protect.
Thanks,
-Kai
Btw I also think this patch can be merged with patch 6.
We can not as it depends on patch 8. ;)
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html