On 02/12/15 11:49, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:50:10PM +0000, Marc Zyngier wrote: >> So far, we've implemented the new world switch with a completely >> different namespace, so that we could have both implementation >> compiled in. >> >> Let's take things one step further by adding weak aliases that >> have the same names as the original implementation. The weak >> attributes allows the new implementation to be overriden by the >> old one, and everything still work. > > Do I understand correctly that the whole point of this is to keep > everything compiling nicely while at the same time being able to split > the patches so that you can have an isolated "remove old code" patch > that doesn't have to change the callers? Exactly. > If so, I think explaining this rationale would be helpful in the commit > message in case we have to go back and track these changes in connection > with a regression and don't remember why we did things this way. Fair enough. I'll update the commit message (possibly by stealing a large part of the above text!). > Maybe I'm being over-cautious though... > > Otherwise: > > Acked-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx> Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
