On Thu, Nov 19, 2015 at 12:10:49PM +0100, Paolo Bonzini wrote: > > > On 19/11/2015 07:36, Han, Huaitong wrote: > > I understand it has always been that QEMU considers the feature of > > cpuid_7_0_ecx_feature_name as migratable. If the feature is > > unmigratable, it will been added to unmigratable_flags. > > > > A series of patches do complete a full function, moving > > cpuid_7_0_ecx_feature_name to 2/3 patch may make 2/3 patch look > > better, but make 1/3 patch look somewhat incomplete. > > > > Maybe it is a solution that adding the feature to unmigratable_flags in > > 1/3 patch, and deleting unmigratable_flags in 2/3 patch, but I think it > > is pointless. > > Or just squash everything together. After all we're talking of > > 4 files changed, 55 insertions(+), 1 deletion(-) > > It's not a large patch. It makes sense. Adding the state to X86CPU (2/3) is useful only if we migrate it (3/3), and adding the feature names (1/3) is useful only if we can handle the new state. I will squash everything together when applying, in case there's no new version. -- Eduardo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
