On 16/11/2015 03:51, Takuya Yoshikawa wrote: > What kvm_mmu_mark_parents_unsync() does is: > > for each p_i in sp->parent_ptes rmap chain > mark_unsync(p_i); > > Then, mark_unsync() finds the parent sp including that p_i to > set ->unsync_child_bitmap and increment ->unsync_children if > necessary. It may also call kvm_mmu_mark_parents_unsync() > recursively. I agree. sp->parent_ptes goes up one level from sp; kvm_mmu_mark_parents_unsync(sp) visits the level above sp, while mark_unsync(sp) visit sp and all the levels above it. Calling mark_unsync(parent_pte) is enough to complete the visit, after kvm_mmu_mark_parents_unsync has already processed the level above sp. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
