On Tue, Nov 17, 2015 at 10:07:53PM +0800, Haozhong Zhang wrote: > On 11/17/15 11:32, Eduardo Habkost wrote: > > On Tue, Nov 17, 2015 at 01:20:38PM +0800, Haozhong Zhang wrote: > > > Following two changes are made to the TSC rate setting code in > > > kvm_arch_init_vcpu(): > > > * The code is moved to a new function kvm_arch_set_tsc_khz(). > > > * If setting user-specified TSC rate fails and the host TSC rate is > > > inconsistent with the user-specified one, print a warning message. > > > > > > Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx> > > > > This matches what I was expecting, and now I see that we don't > > even need the user_tsc_khz field. > > > > I guess you mean the user_tsc_khz field is not needed when setting TSC > rate. It's still needed in patch 3 to check if the migrated TSC rate > is consistent with the user-specified TSC rate (and of course it's not > in kvm_arch_set_tsc_khz()). Yes, I was looking only at the error-checking logic in kvm_arch_init_vcpu(). Then I noticed user_tsc_khz was added for the migration sanity check (which makes sense). -- Eduardo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
