Am 09.11.2015 um 13:24 schrieb Paolo Bonzini: > On 09/11/2015 12:55, Huaitong Han wrote: >> @@ -351,6 +362,7 @@ static const char *cpuid_6_feature_name[] = { >> CPUID_7_0_EBX_FSGSBASE, CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2, >> CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM, >> CPUID_7_0_EBX_RDSEED */ >> +#define TCG_7_0_ECX_FEATURES (CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE) > > This should be zero. Apart from this detail, the QEMU parts look good. ...except for the subjects, which should be "target-i386: add pkeys support for cpuid handling" etc. - no need to put qemu into a QEMU commit subject, especially not twice. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html