Hi Arnd, On 10/23/2015 03:12 PM, Arnd Bergmann wrote: > On Friday 23 October 2015 14:37:14 Eric Auger wrote: >> Remove the static lookup table and use the dynamic list of registered >> reset functions instead. Also load the reset module through its alias. >> The reset struct module pointer is stored in vfio_platform_device. >> >> We also remove the useless struct device pointer parameter in >> vfio_platform_get_reset. >> >> This patch fixes the issue related to the usage of __symbol_get, which >> besides from being moot, prevented compilation with CONFIG_MODULES >> disabled. >> >> Also usage of MODULE_ALIAS makes possible to add a new reset module >> without needing to update the framework. This was suggested by Arnd. >> >> Signed-off-by: Eric Auger <eric.auger@xxxxxxxxxx> >> Reported-by: Arnd Bergmann <arnd@xxxxxxxx> >> >> > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > > but doesn't this need to come before patch 4/7? Well I don't think so. In [4] we introduce the dynamic registration method but until this patch we still use the old lookup method in the static table. I tested and the reset lookup still works in [4]. If we put this one before the registration, the functionality will be lost here. Eric > Arnd > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
