On 10/19/2015 03:39 PM, Michael S. Tsirkin wrote:
On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote:
+ nvdimm_init_memory_state(&pcms->nvdimm_memory, system_memory, machine,
+ TARGET_PAGE_SIZE);
+
Shouldn't this be conditional on presence of the nvdimm device?
We will enable hotplug on nvdimm devices in the near future once Linux driver is
ready. I'd keep it here for future development.
No, I don't think we should add stuff unconditionally. If not nvdimm,
some other flag should indicate user intends to hotplug things.
Actually, it is not unconditionally which is called if parameter "-m aaa, maxmem=bbb"
(aaa < bbb) is used. It is on the some path of memoy-hotplug initiation.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
