On Thu, Oct 08, 2015 at 09:52:02AM +0300, Pavel Fedin wrote: > Hello! > > > > --- a/Documentation/virtual/kvm/devices/arm-vgic.txt > > > +++ b/Documentation/virtual/kvm/devices/arm-vgic.txt > > > @@ -44,28 +44,29 @@ Groups: > > > Attributes: > > > The attr field of kvm_device_attr encodes two values: > > > bits: | 63 .... 40 | 39 .. 32 | 31 .... 0 | > > > - values: | reserved | cpu id | offset | > > > + values: | reserved | cpu idx | offset | > > > > why should this be changed to cpu idx? > > Because it's index (from 0 to N - 1), and "cpu id" may confuse readers that it should be MPIDR > affinity value. In register access function we do "vcpu = kvm_get_vcpu(dev->kvm, cpuid);" (see here: > http://lxr.free-electrons.com/source/virt/kvm/arm/vgic-v2-emul.c#L664), and kvm_get_vcpu just > indexes the array: http://lxr.free-electrons.com/source/include/linux/kvm_host.h#L427 > I decided to change this after http://www.spinics.net/lists/kvm-arm/msg16359.html, Andre clearly > mistook this ID for being affinity value. > Before GICv3 nobody saw the difference because we had only up to 16 CPUs, with IDs from 0 to 15, i. > e. corresponding to indexes. > ok, fair enough. This kind of rationale is helpful to put in the commit text though. -Christoffer -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
