On 17/09/2015 17:27, Arjan van de Ven wrote: >> >>> ( We should double check that rdmsr()/wrmsr() results are never left >>> uninitialized, but are set to zero or so, for cases where the >>> return code is not >>> checked. ) >> >> It sure looks like native_read_msr_safe doesn't clear the output if >> the rdmsr fails. > > I'd suggest to return some poison not just 0... What about 0 + WARN? Paolo > less likely to get interesting surprises that are insane hard to > debug/diagnose -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html