On 17/09/2015 03:51, Wu, Feng wrote: > > >> -----Original Message----- >> From: Paolo Bonzini [mailto:pbonzini@xxxxxxxxxx] >> Sent: Wednesday, September 16, 2015 5:27 PM >> To: Wu, Feng; alex.williamson@xxxxxxxxxx; joro@xxxxxxxxxx; >> mtosatti@xxxxxxxxxx >> Cc: eric.auger@xxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; >> iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct >> kvm_kernel_irqfd' >> >> >> >> On 16/09/2015 10:50, Feng Wu wrote: >>> +int kvm_arch_update_irqfd_routing(struct kvm *kvm, unsigned int host_irq, >>> + uint32_t guest_irq, bool set) >>> +{ >>> + return !kvm_x86_ops->update_pi_irte ? -EINVAL : >>> + kvm_x86_ops->update_pi_irte(kvm, host_irq, guest_irq, set); >>> +} >>> + >> >> Just use "if" here. No need to resend if this is the only comment. > > I am sorry, I don't quite understand. Do you mean I don't need to include > this patch in v9? If so, what about other patches with your Reviewed-by? No, I just wrote this email first. If this was the only comment, I could have fixed it up myself. But since there were a few other comments, please send v9 with all the required changes. Thanks, Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html