Hi Wei, On 2015/9/17 13:56, Wei Huang wrote: > > > On 09/16/2015 08:32 PM, Shannon Zhao wrote: >> Hi Wei, >> >> On 2015/9/17 5:07, Wei Huang wrote: >>> I am testing this series. >> Thanks for your time and help. >> >>> The first question is: do you plan to add ACPI >>> support in QEMU? > > I saw "KVM_{SET/GET}_DEVICE_ATTR failed: Invalid argument" while using > your QEMU tree (PMU_v2 branch). A quick debugging: > >From this log, it might fail at below check: + if (reg < VGIC_NR_SGIS || reg > dev->kvm->arch.vgic.nr_irqs) + return -EINVAL; > (1) dmesg on host kernel didn't show any vPMU initialization errors. So > I suspect the problem is related to QEMU. > (2) Commit 58771bc2a78 worked fine. So probably the problem was > introduced by new PMU code. > > Have you seen it before? > Oh, I didn't see this. And I checkout the code on git.linaro.org, it's same with my local code. Could you add some print in kvm_arm_pmu_set_irq of hw/misc/arm_pmu_kvm.c and kvm_arm_pmu_set_attr, kvm_arm_pmu_set_irq of virt/kvm/arm/pmu.c. Thanks, -- Shannon -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html