Yaniv Kamay wrote:
Hi, Attaching patch that: 1. Fix physical memory live migration. - Stop dirty memory tracking after completion of memory transfer.- In stage 3, updating dirty memory bits before collecting remaining dirty blocks in order to prevent missing dirty blokes in the range of current_addr to phys_ram_size whileno dirty blocks exist in the range 0 - (current_addr - 1) 2. Improve migration error handling
Please split into three separate patches.
+void qemu_file_set_has_error(QEMUFile *f);
Better named qemu_file_set_error()?
diff --git a/qemu/vl.c b/qemu/vl.c index 7ae266e..405212f 100644 --- a/qemu/vl.c +++ b/qemu/vl.c @@ -3221,8 +3221,14 @@ static int ram_save_block(QEMUFile *f) int found = 0;while (addr < phys_ram_size) {- if (kvm_enabled() && current_addr == 0) - kvm_update_dirty_pages_log(); /* FIXME: propagate errors */ + if (kvm_enabled() && current_addr == 0) { + int r; + if ((r = kvm_update_dirty_pages_log())) {
Compare against negative; it could return positive numbers in the future even on no error.
+ printf("%s: update dirty pages log failed %d\n", __FUNCTION__, r);
qemu_log (in qemu-log.h) -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
