Hi Eduardo,
Thank you for reviewing my patches.
On 08/29/2015 01:25 AM, Eduardo Habkost wrote:
On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote:
NVDIMM reserves all the free range above 4G to do:
- Persistent Memory (PMEM) mapping
- implement NVDIMM ACPI device _DSM method
Signed-off-by: Xiao Guangrong <guangrong.xiao@xxxxxxxxxxxxxxx>
[...]
@@ -1302,6 +1303,7 @@ FWCfgState *pc_memory_init(MachineState *machine,
MemoryRegion *ram_below_4g, *ram_above_4g;
FWCfgState *fw_cfg;
PCMachineState *pcms = PC_MACHINE(machine);
+ ram_addr_t offset;
"offset" is a very generic name. I suggest naming it "nvdimm_offset".
'offset' is used for generic proposal as it is not only used for nvdimm but
also for calculating hotplug_mem_base:
pcms->hotplug_memory.base = ROUND_UP(offset, 1ULL << 30);
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
