On 12/08/2015 22:03, Christian Borntraeger wrote: >> > #if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS) >> > - if (ioctl == KVM_S390_INTERRUPT || ioctl == KVM_S390_IRQ || ioctl == KVM_INTERRUPT) >> > - return kvm_arch_vcpu_ioctl(filp, ioctl, arg); >> > + case KVM_S390_INTERRUPT: >> > + case KVM_S390_IRQ: >> > + case KVM_INTERRUPT: > When you are it you might want to put the KVM_S390* withing CONFIG_S390 and > KVM_INTERRUPT within CONFIG_PPC || CONFIG_MIPS > > This might speed up the switch statement for s390/ppc/mips a tiny bit. It will add > another ifdef, though. Paolo? Sure. I wasn't sure of KVM_INTERRUPT's usage on s390. I'm okay with keeping the switch inline too, but if Radim prefers a function that's also fine. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
