Re: [PATCH v7 1/4] KVM: x86: Split the APIC from the rest of IRQCHIP.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 30, 2015 at 11:38:20AM +0200, Paolo Bonzini wrote:
> 
> 
> On 30/07/2015 10:37, Steve Rutherford wrote:
> > This looks a bit non-sensical, but is overprepared for the introduction
> > IOAPIC hotplug, which two patches down the line. Changing it is fine,
> > you'll just need to merge the very same change back.
> 
> By "IOAPIC hotplug" you mean changing the number of reserved routes?  Is
> it necessary?  You could just reserve a bunch of routes depending on the
> maximum number of IOAPICs.
Hmm. Yeah, I think that might be cleaner. Thinking about it, I'm a bit nervous
about the idea of the number of reserved routes shrinking. We would have needed
to trigger an IOAPIC scan if the number of reserved routes changed.

Jan might have an opinion here.

> 
> And especially, is it documented? :)  The docs say "Fails [...] if the
> irqchip is already in the kernel (i.e. KVM_CREATE_IRQCHIP has already
> been called)".
The documentation was out of date D: 

> 
> As before, no need to resend patches for now.  Let's finish discussing
> all pending points, then I'll push what I have to kvm.git and you can
> test it with your VMM.  There should be time between this week and the next.
> 
> Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux