Am 30.07.2015 um 13:38 schrieb Paolo Bonzini: > > > On 30/07/2015 13:22, Christian Borntraeger wrote: >> static int kvm_s390_handle_requests(struct kvm_vcpu *vcpu) >> { >> - if (!vcpu->requests) >> - return 0; >> retry: >> kvm_s390_vcpu_request_handled(vcpu); >> + if (!vcpu->requests) >> + return 0; >> /* > > Should kvm_s390_vcpu_request_handled(vcpu); go before the retry label? > > It shouldn't be too common to have two requests, and you're doing an > extra atomic operation to clear PROG_REQUEST. Handling a request is slow path anyway and my last optimization was not considering all side effects - so give me some time to comsume your comment to make it better this time.... [...] > This of course should be for 4.3 yes :-) > ---I've pulled your branch into kvm/master. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html