Re: [kvm-unit-tests PATCH] alloc: only warn once if we run out of log entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 29, 2015 at 03:52:51PM +0200, Paolo Bonzini wrote:
> 
> 
> On 24/07/2015 14:07, Andrew Jones wrote:
> > @@ -58,6 +59,7 @@ void phys_alloc_set_minimum_alignment(phys_addr_t align)
> >  static phys_addr_t phys_alloc_aligned_safe(phys_addr_t size,
> >  					   phys_addr_t align, bool safe)
> >  {
> > +	static bool not_warned = true;
> 
> I wouldn't object to not having "not" in the name of this variable. :)

yeah, actually I don't like the not in there either, now that you mention
it. v2 coming.

Thanks,
drew

> 
> Otherwise looks okay.
> 
> Paolo
> 
> >  	phys_addr_t addr, size_orig = size;
> >  	u64 top_safe = top;
> >  
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux